Add build utility to check cluster health over ssl#40573
Merged
tvernum merged 3 commits intoelastic:masterfrom Apr 1, 2019
Merged
Add build utility to check cluster health over ssl#40573tvernum merged 3 commits intoelastic:masterfrom
tvernum merged 3 commits intoelastic:masterfrom
Conversation
By default, in integ tests we wait for the standalone cluster to start by using the ant Get task to retrieve the cluster health endpoint. However the ant task has no facilities for customising the trusted CAs for a https resource, so if the integ test cluster has TLS enabled on the http interface (using a custom CA) we need a separate utility for that purpose.
tvernum
added
>test
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
alpar-t
reviewed
Mar 28, 2019
Contributor
alpar-t
left a comment
alpar-t
left a comment
There was a problem hiding this comment.
Thanks! I really like this change, much better to have stuff like this in buildSrc implemented in java and with tests.
I left a single comment.
| this.password = password; | ||
| } | ||
|
|
||
| public boolean wait(int durationInMs) throws GeneralSecurityException, InterruptedException, IOException { |
Contributor
There was a problem hiding this comment.
Could we refactor this to separate the wait/retry logic from the actual check ?
This will be useful for testclusters too, where a boolean return code is not needed and the wait/retry logic is provided for all cluster checks, but even if we don't consider that use-case I think separating these would make it much easier to read.
Contributor
There was a problem hiding this comment.
👍 to some kind of generic wait and retry utility if we don't already have one.
Contributor
|
As it is this utility will only work with via HTTPS if some custom truststore info is provided. Do we think we'll ever have a desire to use this yet not provide a custom truststore? |
Contributor
Author
|
@mark-vieira That's not intentional. If you pass |
Contributor
|
I think I was reading the logic wrong. I interpreted it to be that an error would be thrown in that case but you are right, it looks like it should just use the default SSLContext in that scenario. Disregard. |
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Apr 1, 2019
By default, in integ tests we wait for the standalone cluster to start by using the ant Get task to retrieve the cluster health endpoint. However the ant task has no facilities for customising the trusted CAs for a https resource, so if the integ test cluster has TLS enabled on the http interface (using a custom CA) we need a separate utility for that purpose. Resolves: elastic#38072 Backport of: elastic#40573
tvernum
added a commit
that referenced
this pull request
Apr 4, 2019
By default, in integ tests we wait for the standalone cluster to start by using the ant Get task to retrieve the cluster health endpoint. However the ant task has no facilities for customising the trusted CAs for a https resource, so if the integ test cluster has TLS enabled on the http interface (using a custom CA) we need a separate utility for that purpose. Backport of: #40573
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Apr 5, 2019
By default, in integ tests we wait for the standalone cluster to start by using the ant Get task to retrieve the cluster health endpoint. However the ant task has no facilities for customising the trusted CAs for a https resource, so if the integ test cluster has TLS enabled on the http interface (using a custom CA) we need a separate utility for that purpose. Backport of: elastic#40573
tvernum
added a commit
that referenced
this pull request
Apr 8, 2019
By default, in integ tests we wait for the standalone cluster to start by using the ant Get task to retrieve the cluster health endpoint. However the ant task has no facilities for customising the trusted CAs for a https resource, so if the integ test cluster has TLS enabled on the http interface (using a custom CA) we need a separate utility for that purpose. Backport of: #40573
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Apr 8, 2019
By default, in integ tests we wait for the standalone cluster to start by using the ant Get task to retrieve the cluster health endpoint. However the ant task has no facilities for customising the trusted CAs for a https resource, so if the integ test cluster has TLS enabled on the http interface (using a custom CA) we need a separate utility for that purpose. Resolves: elastic#38072 Backport of: elastic#40573
tvernum
added a commit
that referenced
this pull request
Apr 8, 2019
By default, in integ tests we wait for the standalone cluster to start by using the ant Get task to retrieve the cluster health endpoint. However the ant task has no facilities for customising the trusted CAs for a https resource, so if the integ test cluster has TLS enabled on the http interface (using a custom CA) we need a separate utility for that purpose. Backport of: #40573
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
By default, in integ tests we wait for the standalone cluster to start by using the ant Get task to retrieve the cluster health endpoint. However the ant task has no facilities for customising the trusted CAs for a https resource, so if the integ test cluster has TLS enabled on the http interface (using a custom CA) we need a separate utility for that purpose. Resolves: elastic#38072
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, in integ tests we wait for the standalone cluster to start
by using the ant Get task to retrieve the cluster health endpoint.
However the ant task has no facilities for customising the trusted
CAs for a https resource, so if the integ test cluster has TLS enabled
on the http interface (using a custom CA) we need a separate utility
for that purpose.
Closes: #38072